I fixed "e-mail Admins"
Now I'm confused as to how the original code works....
On the email form (php code), there is a line:
<input type="radio" name="replyto" value="<? echo "$_user->name <$_user->email>" ?>" checked>
edit: the value of the field becomes something like: user_name <user@usersisp.com>
If I change the value to just be the user's email (without the < and >) then it works. The way it was before, the code was seeing the value as just the user name, which it was rejecting as not being a valid email address.
If I change the value to just be the user's email (without the < and >) then it works. The way it was before, the code was seeing the value as just the user name, which it was rejecting as not being a valid email address.
I have a vague memory of having that problem when I set up the first voting page. I based some of the code on the Email an Admin page. There's a subroutine that checks for valid email addresses and it was checking on the whole user_name <user@usersisp.com> thingie. On the voting page, I changed the code so that it only validated the email address part.
I meant to send a note to ita about fixing the Email an Admin page but I must have forgotten.
Unfortunately I don't have the brain cells to easily debug the regular expression in the check -- I think that it may have been a particular character legal in the username that was throwing it off.
Because it doesn't always fail, does it? Have we had that big a bug this whole time?
Have we had that big a bug this whole time?
I think so, yes. At least,
I
couldn't get it to work.
The problem looks like when the form loads, the replyto field on the form has a vaule of the user name and the user email address, when it only needs to have the email address. When the user submist the form, both the user name and the user email gets posted to the server, causing the email validity testing function to return false.
I think. I don't have the whole code in front of me, as I'm watching X-men United.
edit: I don't understand how the code for buffistas.org does works... unless that code is different.
I went and tested and it works just fine for me -- it may very well be punctuation in the username that sets it off.
We'll need to put that on the list, and hope someone with regex knowhow steps up for it.
tommy -- you have precisely the code that's running here.
The problem's not with regex. The function with the regex test was getting passed the user name, not the user email.
I'll have more details after X-Men is over.
The function with the regex test was getting passed the user name, not the user email.
I'll go dig into the code, but since it seems to think "ita" is a valid e-mail address, then we do have a problem with the regex anyway.
So thanks, Gus.
Cool. Point me at it, via the profile addy...
