Look, Angel, I know you've been out of the loop for a while, but I'm still evil. I don't do errands...unless they're evil errands.

Lilah ,'Just Rewards (2)'


Buffistas Building a Better Board  

Do you have problems, concerns or recommendations about the technical side of the Phoenix? Air them here. Compliments also welcome.

To-do list


Karl - Jun 09, 2004 7:12:17 pm PDT #7943 of 10000
I adore all you motherfuckers so much -- PMM.

The regex is supposed to be able to accept "Jon. B " as a valid e-mail address. It is not. However, it likes "ita " just fine. Which is why the problem is not in what's passed, but in how it's parsed.

ita <ita@example.com> is a valid rfc822 address.
Jon B <jonb@somewhere.com> is also valid.
Jon B. <jonb@somewhere.com> is not -- unquoted periods are not allowed in the "user name" portion outside the <> pair.
"Jon B." <jonb@somewhere.com> is valid, however.

ita, try putting quotes around "Jon B." in your test, and see if it passes. If so, then your address parser is probably just obeying rfc822.


Katie M - Jun 09, 2004 7:12:54 pm PDT #7944 of 10000
I was charmed (albeit somewhat perplexed) by the fannish sensibility of many of the music choices -- it's like the director was trying to vid Canada. --loligo on the Olympic Opening Ceremonies

Here's a seemingly-out-of-nowhere request (which obviously is not urgent): Is there any way to make the highlighted text under whitefont any darker? I find the blue difficult to read.


§ ita § - Jun 09, 2004 7:18:54 pm PDT #7945 of 10000
Well not canonically, no, but this is transformative fiction.

Is there any way to make the highlighted text under whitefont any darker? I find the blue difficult to read.

I think that's your browser. The code just makes it white.

Thanks for that tip, Karl. Let me try.


Jon B. - Jun 09, 2004 7:19:56 pm PDT #7946 of 10000
A turkey in every toilet -- only in America!

That's a browser thing, not a code thing, Katie. No idea if there's a browser setting you could change for that...

t /not helpful

Y'know, I added a period to my username specifically to see if it would break things.... Glad to see it's still useful.


§ ita § - Jun 09, 2004 7:31:29 pm PDT #7947 of 10000
Well not canonically, no, but this is transformative fiction.

Karl, I've changed the code to quote properly, but it still breaks the regex. Gus is on the case.


tommyrot - Jun 09, 2004 7:48:19 pm PDT #7948 of 10000
Sir, it's not an offence to let your cat eat your bacon. Okay? And we don't arrest cats, I'm very sorry.

Yes, but if Gus can help us fix the regex (I have a version in my inbox already) simply, we might as well go with that.

Unless I misunderstand things, the user name doesn't actually do anything. It's just part of the value that gets returned to the server if the user accepts the default email address for the "from" part of the email. (If the user does not accept the default but types in her own "from" address, the server gets the email address without the user name.)

Fixing that is easy. In the code that sets up the form, just change

<input type="radio" name="replyto" value="<? echo "$_user->name <$_user->email>" ?>" checked>

to

<input type="radio" name="replyto" value="<? echo $_user->email ?>" checked>

eta: I can send e-mail to the admins at .net just fine

Oh, I missed that. The fixed version of email.php was there when you tried.


Gus - Jun 09, 2004 7:57:12 pm PDT #7949 of 10000
Bag the crypto. Say what is on your mind.

My email just went down, so ....

Well this sux. The board keeps wrecking the expression.

Wait one, I'll post it on my site.

Here we go mock code.

It doesn't catch mismatched quotes in the name, but all three etsts in the script pass a success back.


Jon B. - Jun 09, 2004 7:57:38 pm PDT #7950 of 10000
A turkey in every toilet -- only in America!

Tommy - take a look at the code on the vote pages (under the votes directory. I know my code works because it's been used a lot. I fixed exactly what you're talking about.


§ ita § - Jun 09, 2004 8:03:14 pm PDT #7951 of 10000
Well not canonically, no, but this is transformative fiction.

I get that, tommy. But if it's not hard to send a neatly formatted e-mail, why not? If it is hard, then we can bag it.

Gus, why don't you just e-mail it to me in the morning? Cutting and pasting from the mangled stuff here (which should also be put on the to-fix list) confuses and makes things odd.


tommyrot - Jun 09, 2004 8:07:58 pm PDT #7952 of 10000
Sir, it's not an offence to let your cat eat your bacon. Okay? And we don't arrest cats, I'm very sorry.

But if it's not hard to send a neatly formatted e-mail, why not?

Oh. Duh. I didn't realize that the user name actually does something--it's what's displayed in the email itself. I just didn't see why it was there in the first place.