Absolutely on both board health and more work. That's why I wanted to check with you and Tom rather than just demanding a filter yesterday. Let me know if/when I can help.
Jayne: Anybody remember her comin' at me with a butcher's knife? Wash: Wacky fun.
'Objects In Space'
Buffistas Building a Better Board
Do you have problems, concerns or recommendations about the technical side of the Phoenix? Air them here. Compliments also welcome.
amych - Jan 09, 2004 4:31:11 am PST #6511 of 10000
Now let us crush something soft and watch it fountain blood. That is a girlish thing to want to do, yes?
Tom Scola - Jan 09, 2004 5:30:24 pm PST #6512 of 10000
Remember that the frontier of the Rebellion is everywhere. And even the smallest act of insurrection pushes our lines forward.
MySQL was originally designed as a database with -very- (compared to something like PostgreSQL or Oracle) lightweight connections. Let's try hard to quantify the difference here before we talk about re-writing whole sections of code.
On the test board, I made a copy of giles.php, and changed a few lines so that one mysql connection is made at the beginning of the session, rather than with each connectAndQuery call. I then ran some benchmarks.
Without the change, index.php took an average of 0.1032 seconds to load. With the change it averaged 0.0813 seconds. (index.php makes 6 connectAndQuery calls).
A slightly heavier page, showthread.php averaged 0.2287 seconds before the change, and 0.1863 seconds after. (it makes 25 connectAndQuery calls).
A threadsuck of a 10,000 post thread took 57.75 seconds, during which the load average on the system went from 0.40 and peaked at 1.78. With the change, the threadsuck took 46.54 seconds, and the load average went from 0.40 and peaked at 1.20.
Not as big of an improvement as I was expecting, but still significant.
DCJensen - Jan 09, 2004 9:54:10 pm PST #6513 of 10000
All is well that ends in pizza.
It's the fractions that add up when no one is looking (See Office Space ).
Karl - Jan 09, 2004 10:28:34 pm PST #6514 of 10000
I adore all you motherfuckers so much -- PMM.
Can I just mention now how much Tom Scola rocks the house?
Because he most definitely does.
Jesse - Jan 10, 2004 4:52:57 am PST #6515 of 10000
Sometimes I trip on how happy we could be.
Right on, Karl.
§ ita § - Jan 10, 2004 6:41:36 am PST #6516 of 10000
Well not canonically, no, but this is transformative fiction.
Not as big of an improvement as I was expecting, but still significant.
And we should be realising them now -- I made those changes here: ita "Buffistas Building a Better Board" Jan 8, 2004 5:14:19 pm PST.
The fun bit will be modifying the queries to return line by line, not multi-record recordsets.
Tom Scola - Jan 10, 2004 7:10:17 am PST #6517 of 10000
Remember that the frontier of the Rebellion is everywhere. And even the smallest act of insurrection pushes our lines forward.
Unless I'm missing someting, I think the changes I made are different than yours, ita. There's only one db_connect per session in my version.
Take a look at gilesSCOLA.php on the test board. The changes I made are surrounded with rows of "@"s.
§ ita § - Jan 10, 2004 7:42:34 am PST #6518 of 10000
Well not canonically, no, but this is transformative fiction.
There's only one db_connect per session in my version.
By session you mean a larger scope than page load?
runs off to check code
Interesting. From the docs ("If a second call is made to mysql_connect() with the same arguments, no new link will be established, but instead, the link identifier of the already opened link will be returned") the code shouldn't make another connection, just because the command is called again once it's open, and it'll be open in the current code because it's not closed until the implicit close at the end of any page.
Which shouldn't be any different in terms of MySQL load from you opening it at the top of the page.
Perhaps the time saving is because it doesn't do the "check and return nothing different"?
Tom Scola - Jan 10, 2004 7:47:12 am PST #6519 of 10000
Remember that the frontier of the Rebellion is everywhere. And even the smallest act of insurrection pushes our lines forward.
Hmmm. Let me run some more benchmarks.
Tom Scola - Jan 10, 2004 8:08:52 am PST #6520 of 10000
Remember that the frontier of the Rebellion is everywhere. And even the smallest act of insurrection pushes our lines forward.
OK, it looks like you're right, ita; your changes are equivalent. I just didn't realize that php was doing something implicit with mysql_connect.